Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kumactl) support plugin based authentication including user tokens #2895

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

This PR introduces support of custom plugin-based authentication to the control plane. Plugins are loosely typed so there are two arguments --auth-type and --auth-conf. This way we can define any key-value properties of an auth plugin.

Projects that build on top of Kuma can add their own plugins using RootContext.

Documentation

  • Will provide docs when full E2E auth story is done.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No backporting.

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 5, 2021 14:29
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from user-token to master October 8, 2021 13:49
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants