feat(kuma-cp) initial connection policy support for Gateway #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
+ Coverage 52.28% 52.40% +0.11%
==========================================
Files 909 912 +3
Lines 52431 52515 +84
==========================================
+ Hits 27413 27519 +106
+ Misses 22825 22799 -26
- Partials 2193 2197 +4
Continue to review full report at Codecov.
|
jpeach
changed the title
jakubdyszkiewicz
approved these changes
Oct 14, 2021
Gateway resources create connections from the gateway (source) to services running in the mesh (destination). Add support for matching connection policies based on these sources and destinations. The sources for connection policies are gateway listeners, but the destinations aren't known until we process the relevant gateway route types. So, we cache the policies that matched on the source (along with their match rank) on each virtual host, and complete the match once the final route table has been built. Note that some Kuma connection policies are implemented by configuring both the Envoy HTTP connection manager and the relevant upstream cluster. These connection policies cannot be implemented in Gateway, since they cannot configure the HTTP connection manager with different setting for each destination. Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
Gateway resources create connections from the gateway (source) to services running in the mesh (destination). Add support for matching connection policies based on these sources and destinations. The sources for connection policies are gateway listeners, but the destinations aren't known until we process the relevant gateway route types. So, we cache the policies that matched on the source (along with their match rank) on each virtual host, and complete the match once the final route table has been built. Note that some Kuma connection policies are implemented by configuring both the Envoy HTTP connection manager and the relevant upstream cluster. These connection policies cannot be implemented in Gateway, since they cannot configure the HTTP connection manager with different setting for each destination. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit c10ab8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gateway resources create connections from the gateway (source) to
services running in the mesh (destination). Add support for matching
connection policies based on these sources and destinations.
The sources for connection policies are gateway listeners, but the
destinations aren't known until we process the relevant gateway route
types. So, we cache the policies that matched on the source (along with
their match rank) on each virtual host, and complete the match once the
final route table has been built.
Note that some Kuma connection policies are implemented by configuring
both the Envoy HTTP connection manager and the relevant upstream
cluster. These connection policies cannot be implemented in Gateway,
since they cannot configure the HTTP connection manager with different
setting for each destination.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.