feat(kuma-cp) give CA managers all backends at once #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2956 +/- ##
==========================================
+ Coverage 52.37% 52.40% +0.03%
==========================================
Files 912 912
Lines 52517 52520 +3
==========================================
+ Hits 27505 27525 +20
+ Misses 22819 22800 -19
- Partials 2193 2195 +2
Continue to review full report at Codecov.
|
jpeach
approved these changes
Oct 17, 2021
There was a problem hiding this comment.
This change looks fine.
I would suggest expanding the commit message to explain why this change is needed. I'm assuming that it makes some subsequent change easier. If so, including the explanation in the commit message makes life easier for PR review, but also for people who will look at and try to understand the context of this change in a year from now.
jakubdyszkiewicz
approved these changes
Oct 18, 2021
michaelbeaumont
force-pushed
the
feat/ca_manager_active
branch
from
11a9dac
to
c5fb860
Compare
Co-authored-by: James Peach <james.peach@konghq.com> Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/ca_manager_active
branch
from
714d308
to
f269bb8
Compare
michaelbeaumont
added a commit
that referenced
this pull request
Oct 22, 2021
This reverts commit c586219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows CA managers to know all of the relevant backends during the
Enablestep . A manager is then able to, for example, remove state used to maintain previous backends that may no longer exist.