kuma-cp: add k8s Admission Web Hook to apply defaults to Mesh resources #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/k8s-admission-webhook
branch
3 times, most recently
from
bd5c521
to
eb63537
Compare
| xdsServer: | ||
| grpcPort: 0 | ||
| diagnosticsPort: %d | ||
| diagnosticsPort: %%d |
There was a problem hiding this comment.
How does it work? What does double % mean?
There was a problem hiding this comment.
% escapes another %, so %%d will become %d after passing thorugh fmt.Sprintf
| address: | ||
| # Port the Admission WebHook Server should be listening on | ||
| port: 5443 | ||
| # Directory with a TLS cert and private key for the Admission WebHook Server |
There was a problem hiding this comment.
How about keeping comments the same as in code?
yskopets
force-pushed
the
feature/k8s-admission-webhook
branch
from
eb63537
to
8b14573
Compare
yskopets
changed the base branch from
feature/introduce-runtime-plugin
to
feature/default-mesh-on-k8s
yskopets
force-pushed
the
feature/k8s-admission-webhook
branch
from
60306dd
to
7ca9354
Compare
yskopets
force-pushed
the
feature/default-mesh-on-k8s
branch
from
1aaa16d
to
f5fb69f
Compare
jakubdyszkiewicz
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
k8s Admission WebHookto apply defaults toMeshresources, such asbuilt-in CAk8s Admission WebHook ServerusingRuntimePluginkumactl install control-planerespectively