Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) aggregate dp stats by type in MeshInsight #2999

Merged

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Oct 25, 2021

Summary

Currently we are returning only stats (total/online/offline) without distinction for the dp types (standard/gateway), I added dataplanesByType property to MeshInsights where stats are aggregated by these types.

Full changelog

no changelog

Issues resolved

no issue resolved

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner October 25, 2021 09:28
@codecov-commenter
Copy link

Codecov Report

Merging #2999 (7d4b69d) into master (7e40b0f) will increase coverage by 0.06%.
The diff coverage is 56.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
+ Coverage   52.21%   52.28%   +0.06%     
==========================================
  Files         912      912              
  Lines       52736    52788      +52     
==========================================
+ Hits        27538    27599      +61     
+ Misses      23004    22994      -10     
- Partials     2194     2195       +1     
Impacted Files Coverage Δ
api/mesh/v1alpha1/mesh_insight.pb.go 32.38% <42.85%> (+3.54%) ⬆️
pkg/insights/resyncer.go 69.75% <100.00%> (+1.90%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-4.26%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
pkg/mads/server/server.go 85.18% <0.00%> (+2.77%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e40b0f...7d4b69d. Read the comment docs.

@bartsmykla bartsmykla merged commit 21b0d4d into kumahq:master Oct 26, 2021
@bartsmykla bartsmykla deleted the feat/aggregate-dp-stats-by-type branch October 26, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants