Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-plane: adjust Core Model and Core Client APIs #30

Merged
merged 2 commits into from
Jun 20, 2019
Merged

control-plane: adjust Core Model and Core Client APIs #30

merged 2 commits into from
Jun 20, 2019

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Jun 20, 2019 •
edited

Changes:

  • SetMeta(ResourceMeta) method has been added to model.Resource
  • NewItem() Resource and AddItem(Resource) error methods have been added to model. ResourceList
  • client.NewStrictResourceClient() function has been added to decorate various client.ResourceClient implementations with consistent validation logic
  • a complete example implementation of client.ResourceClient has been added - see client.example.ExampleResourceClient
  • unit tests for example implementation of client.ResourceClient have been added

@yskopets yskopets self-assigned this Jun 20, 2019
@yskopets yskopets added this to the 0.1 milestone Jun 20, 2019
@yskopets yskopets force-pushed the feature/konvoy-control-plane-core branch from ed1dab5 to 76aff84 Compare June 20, 2019 15:15
@yskopets yskopets merged commit cdc4e0c into master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees

@yskopets yskopets

Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz