Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) rename RBAC to access #3033

Merged
merged 1 commit into from
Oct 28, 2021
Merged

chore(*) rename RBAC to access #3033

merged 1 commit into from
Oct 28, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

RBAC is Role-Based Access Control, when in fact what we have in Kuma is just a static access control to resources. The naming is not correct so this PR changes RBAC to access

Full changelog

  • Rename RBAC to access across the project
  • Remove pkg/rbac since it's not used.

Issues resolved

No issue

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No backporting.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 28, 2021 11:58
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubdyszkiewicz jakubdyszkiewicz merged commit f07e2d4 into master Oct 28, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore-rename-rbac branch October 28, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants