Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing) added support for https tracing endpoint #3057

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

sudeeptoroy
Copy link
Contributor

Summary

added support for https tracing endpoints

Issues resolved

Fix #2613

Testing

  • [ *] Unit tests

Backwards compatibility

  • [* ] backport-to-stable

sudeeptoroy and others added 6 commits August 29, 2021 00:33
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
@sudeeptoroy sudeeptoroy requested a review from a team as a code owner November 1, 2021 14:15
@bartsmykla bartsmykla changed the title Feat/tracing added support for https tracing endpoint feat(tracing) added support for https tracing endpoint Nov 2, 2021
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the contribution!

pkg/xds/envoy/clusters/v3/dns_cluster_configurer_test.go Outdated Show resolved Hide resolved
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lahabana lahabana merged commit 9009059 into kumahq:master Nov 3, 2021
mergify bot pushed a commit that referenced this pull request Nov 3, 2021
Signed-off-by: Sudeepto Roy <sudeepto.roy@gmail.com>
(cherry picked from commit 9009059)

# Conflicts:
#	pkg/xds/envoy/clusters/v3/dns_cluster_configurer_test.go
@sudeeptoroy sudeeptoroy deleted the feat/tracing branch November 4, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support https endpoint for Tracing server.
2 participants