Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) consolidate RSA key generation policy #3080

Merged
merged 1 commit into from
Nov 4, 2021
Merged

chore(*) consolidate RSA key generation policy #3080

merged 1 commit into from
Nov 4, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 4, 2021

Summary

Consolidate the RSA default key length policy into a single
helper utility.

Full changelog

N/A

Issues resolved

Fix #3017.

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Consolidate the RSA default key length policy into a single
helper utility.

This fixes #3017.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner November 4, 2021 00:21
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach
Copy link
Contributor Author

jpeach commented Nov 4, 2021

Not backporting because pkg/util/rsa isn't present on the backport branch.

@jpeach jpeach merged commit 7575883 into kumahq:master Nov 4, 2021
@jpeach jpeach deleted the chore/consolidate-rsa branch November 4, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate RSA key generation
2 participants