Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) automatically enable gzip content on gateways #3104

Merged
merged 1 commit into from
Nov 10, 2021
Merged

feat(kuma-cp) automatically enable gzip content on gateways #3104

merged 1 commit into from
Nov 10, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 9, 2021

Summary

Always configure the compressor filter to enable gzip compression if
the client negotiates the relevant content types. This is a safe and
conservative default that can benefit many clients.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner November 9, 2021 03:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #3104 (3f585e0) into master (40f8aa3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
+ Coverage   52.36%   52.38%   +0.01%     
==========================================
  Files         923      923              
  Lines       53491    53510      +19     
==========================================
+ Hits        28012    28029      +17     
- Misses      23245    23247       +2     
  Partials     2234     2234              
Impacted Files Coverage Δ
.../plugins/runtime/gateway/filter_chain_generator.go 76.10% <100.00%> (+0.15%) ⬆️
...kg/xds/envoy/listeners/filter_chain_configurers.go 97.43% <100.00%> (+0.33%) ⬆️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-5.13%) ⬇️
pkg/insights/resyncer.go 67.22% <0.00%> (-2.68%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+5.19%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f8aa3...3f585e0. Read the comment docs.

Always configure the compressor filter to enable gzip compression if
the client negotiates the relevant content types. This is a safe and
conservative default that can benefit many clients.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach changed the title feat(kuma-cp) automatically ennable gzip content on gateways feat(kuma-cp) automatically enable gzip content on gateways Nov 9, 2021
@jpeach jpeach merged commit 3caf770 into kumahq:master Nov 10, 2021
@jpeach jpeach deleted the feat/gateway-compressor-filter branch November 10, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants