Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-dp) match gateway cluster names in the hijacker #3106

Merged
merged 1 commit into from
Nov 15, 2021
Merged

fix(kuma-dp) match gateway cluster names in the hijacker #3106

merged 1 commit into from
Nov 15, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 9, 2021

Summary

Gateway generates cluster names differently than the outbound proxy
generator, so each the metrics hijacker how to deal with both cluster
name conventions.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #3106 (c8db95c) into master (ba93741) will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
+ Coverage   52.33%   52.37%   +0.03%     
==========================================
  Files         923      923              
  Lines       53578    53573       -5     
==========================================
+ Hits        28040    28057      +17     
+ Misses      23301    23289      -12     
+ Partials     2237     2227      -10     
Impacted Files Coverage Δ
app/kuma-dp/pkg/dataplane/metrics/merge.go 87.83% <81.81%> (+2.21%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 82.75% <0.00%> (-1.15%) ⬇️
pkg/plugins/resources/postgres/store.go 75.52% <0.00%> (+0.84%) ⬆️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/core/managers/apis/mesh/mesh_manager.go 49.38% <0.00%> (+2.46%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (+2.59%) ⬆️
pkg/defaults/mesh/mesh.go 77.77% <0.00%> (+3.70%) ⬆️
pkg/defaults/components.go 92.15% <0.00%> (+3.92%) ⬆️
pkg/defaults/mesh/signing_key.go 76.47% <0.00%> (+11.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba93741...c8db95c. Read the comment docs.

@jpeach jpeach marked this pull request as ready for review November 10, 2021 22:02
@jpeach jpeach requested a review from a team as a code owner November 10, 2021 22:02
Gateway generates cluster names differently than the outbound proxy
generator, so each the metrics hijacker how to deal with both cluster
name conventions.

Signed-off-by: James Peach <james.peach@konghq.com>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpeach jpeach merged commit 4947b37 into kumahq:master Nov 15, 2021
@jpeach jpeach deleted the fix/metrics-hijacker-gateway branch November 15, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants