Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) update some TODO comments #3141

Merged
merged 1 commit into from
Nov 15, 2021
Merged

chore(kuma-cp) update some TODO comments #3141

merged 1 commit into from
Nov 15, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 11, 2021

Summary

Update some comments.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner November 11, 2021 05:52
@codecov-commenter
Copy link

Codecov Report

Merging #3141 (f2c2ffb) into master (f3cf03d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage   52.32%   52.33%   +0.01%     
==========================================
  Files         923      923              
  Lines       53578    53576       -2     
==========================================
+ Hits        28033    28039       +6     
+ Misses      23313    23301      -12     
- Partials     2232     2236       +4     
Impacted Files Coverage Δ
pkg/plugins/runtime/gateway/listener_generator.go 92.85% <ø> (+2.53%) ⬆️
...s/runtime/gateway/route_configuration_generator.go 86.66% <ø> (ø)
...g/plugins/runtime/gateway/route_table_generator.go 100.00% <ø> (ø)
pkg/plugins/runtime/gateway/cluster_generator.go 88.69% <100.00%> (ø)
pkg/plugins/runtime/gateway/route/configurers.go 82.87% <100.00%> (+0.07%) ⬆️
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cf03d...f2c2ffb. Read the comment docs.

@jpeach jpeach merged commit 796d3ed into kumahq:master Nov 15, 2021
@jpeach jpeach deleted the chore/todo-comment-update branch November 15, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants