Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-dp) Add conf to disable service vip #3143

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

lahabana
Copy link
Contributor

Add a switch to make <kuma.io/service>.mesh generation optional.

Motivation:

  • It is only useful in a restricted set of cases (mix universal/k8s, universal only...).
  • It generates a lot of configuration (1 listener per service, entries in the dns filter...)
  • VirtualOutbound can do all this and more

This adds a switch to turn the generation of these off.
In future versions we should remove it altogether and suggest generating specific virtual-outbound instead.

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Add a switch to make `<kuma.io/service>.mesh` generation optional.

Motivation:

- It is only useful in a restricted set of cases (mix universal/k8s, universal only...).
- It generates a lot of configuration (1 listener per service, entries in the dns filter...)
- VirtualOutbound can do all this and more

This adds a switch to turn the generation of these off.
In future versions we should remove it altogether and suggest generating specific virtual-outbound instead.

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner November 12, 2021 13:02
@codecov-commenter
Copy link

Codecov Report

Merging #3143 (ef62ee0) into master (1c8405d) will decrease coverage by 0.07%.
The diff coverage is 30.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3143      +/-   ##
==========================================
- Coverage   52.37%   52.30%   -0.08%     
==========================================
  Files         923      923              
  Lines       53596    53643      +47     
==========================================
- Hits        28072    28059      -13     
- Misses      23291    23347      +56     
- Partials     2233     2237       +4     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/plugin.go 1.12% <0.00%> (-0.01%) ⬇️
test/e2e/virtualoutbound/virtualoutbound_k8s.go 0.00% <0.00%> (ø)
pkg/config/dns-server/config.go 71.42% <100.00%> (+2.19%) ⬆️
pkg/dns/vips_allocator.go 74.50% <100.00%> (+0.50%) ⬆️
pkg/plugins/runtime/universal/plugin.go 68.42% <100.00%> (+1.75%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-5.20%) ⬇️
pkg/api-server/server.go 82.09% <0.00%> (-3.06%) ⬇️
pkg/kds/client/sink.go 59.45% <0.00%> (-2.71%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8405d...ef62ee0. Read the comment docs.

Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahabana lahabana merged commit cdc3b1f into kumahq:master Nov 15, 2021
@lahabana lahabana deleted the feat/disableBuiltInHosts branch March 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants