Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) upgrade to Go 1.17.3 #3147

Merged
merged 1 commit into from
Nov 15, 2021
Merged

chore(*) upgrade to Go 1.17.3 #3147

merged 1 commit into from
Nov 15, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 14, 2021

Summary

Upgrade to Go 1.17.3.

Full changelog

  • Upgraded to build with Go 1.17.3.

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner November 14, 2021 23:09
@codecov-commenter
Copy link

Codecov Report

Merging #3147 (c4ff1b3) into master (1c8405d) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c4ff1b3 differs from pull request most recent head 966ea6d. Consider uploading reports for the commit 966ea6d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   52.37%   52.35%   -0.03%     
==========================================
  Files         923      923              
  Lines       53596    53596              
==========================================
- Hits        28072    28058      -14     
- Misses      23291    23305      +14     
  Partials     2233     2233
Impacted Files Coverage Δ
...s/k8s/native/api/v1alpha1/zz_generated.deepcopy.go 55.88% <ø> (ø)
tools/resource-gen/main.go 0.00% <ø> (ø)
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/api-server/server.go 82.09% <0.00%> (-3.06%) ⬇️
pkg/kds/client/sink.go 59.45% <0.00%> (-2.71%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/core/runtime/reports/reports.go 51.81% <0.00%> (-1.82%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8405d...966ea6d. Read the comment docs.

@jpeach
chore(*) upgrade to Go 1.17.3
7779dfc 
Not only does this upgrade the version of Go, but is also updates various
other build machinery that assumes properties of the Go environment.

- Update the CircleCI clang-format installation on the golang container
  image to not assume a specific Debuan release of llvm version.

- Update the controller-tools build to use "go run", which means that
  we can easily pin a specific version, and its Go code formatting always
  matches the current Go version.

Signed-off-by: James Peach <james.peach@konghq.com>
michaelbeaumont
michaelbeaumont approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpeach jpeach merged commit acfa5ef into kumahq:master Nov 15, 2021
@jpeach jpeach deleted the chore/upgrade-go-117 branch November 15, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpeach @codecov-commenter @michaelbeaumont