Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github) use pull_request_target in GH workflow #3164

Merged
merged 1 commit into from Nov 16, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 16, 2021

It's OK to use pull_request_target because we're not checking out/executing any code from forks.
See the warning about this event type

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 16, 2021 13:42
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

It's OK to use `pull_request_target` because we're not executing any code from forks.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the michaelbeaumont-patch-1 branch 2 times, most recently from 18ce533 to 521d141 Compare November 16, 2021 13:45
@michaelbeaumont michaelbeaumont merged commit db961ec into master Nov 16, 2021
@michaelbeaumont michaelbeaumont deleted the michaelbeaumont-patch-1 branch November 16, 2021 14:13
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Nov 22, 2021
It's OK to use `pull_request_target` because we're not executing any code from forks.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Nov 23, 2021
* refactor(.github) simplify PR merge dispatch (#3144)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* fix(.github) use `pull_request_target` in GH workflow (#3164)

It's OK to use `pull_request_target` because we're not executing any code from forks.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants