Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RELEASE.md) add check item about bumping the Helm chart version #3204

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

michaelbeaumont
Copy link
Contributor

No description provided.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 22, 2021 10:42
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartsmykla bartsmykla enabled auto-merge (squash) November 22, 2021 10:54
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) November 22, 2021 10:56
@codecov-commenter
Copy link

Codecov Report

Merging #3204 (cae318e) into master (5494f86) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3204   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files         928      928           
  Lines       54044    54044           
=======================================
+ Hits        28318    28319    +1     
  Misses      23504    23504           
+ Partials     2222     2221    -1     
Impacted Files Coverage 螖
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-5.20%) 猬囷笍
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) 猬嗭笍
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+10.25%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5494f86...cae318e. Read the comment docs.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 1b9efda into master Nov 22, 2021
@michaelbeaumont michaelbeaumont deleted the docs/release_helm branch November 22, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants