feat(kuma-cp) Initial token generator with HTTP Server on localhost #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
suggested changes
Oct 11, 2019
yskopets
reviewed
Oct 14, 2019
jakubdyszkiewicz
force-pushed
the
feature/initial-token
branch
from
1e67648
to
4c93127
Compare
Do we really need it though? I feel like this is an improvement that can be added later on. |
yskopets
approved these changes
Oct 15, 2019
Comment on lines
38
to
39
| if rt.Config().Environment != config_core.KubernetesEnvironment { | ||
| } |
There was a problem hiding this comment.
What is the purpose of these lines ?
There was a problem hiding this comment.
I think I did a mistake when merging/rebasing. Fixed
|
|
||
| func (a *DataplaneTokenServer) Start(stop <-chan struct{}) error { | ||
| mux := http.NewServeMux() | ||
| mux.HandleFunc("/token", a.handleIdentityRequest) |
There was a problem hiding this comment.
I would expect POST /tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of initial token generator. I added the server that generates JWT token for dataplanes. It listens on http://127.0.0.1:5679. Private key for JWT token is generated on CP startup.
Tokens are not yet used.