kuma-cp: modify generic go-control-plane to always respond to EDS requests that are happening at cluster warming stage
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
Oct 10, 2019
yskopets
force-pushed
the
feature/cluster-warming
branch
from
b9d6b2d
to
6f2b704
Compare
…equests that are happening at cluster warming stage
yskopets
force-pushed
the
feature/cluster-warming
branch
from
6f2b704
to
46e0941
Compare
jackkleeman
referenced
this pull request
in monzo/go-control-plane
Feb 28, 2020
When a cluster is warming, we will receive an endpoint request. If endpoints haven't changed recently, then this request will look stale, and currently we would just leave the watch open. Instead, it is paramount that we respond immediately, otherwise the cluster will get no endpoints. This code is copied verbatim from https://github.com/Kong/kuma/pull/331. Thanks to @yskopets.
jackkleeman
referenced
this pull request
in monzo/go-control-plane
Feb 28, 2020
When a cluster is warming, we will receive an endpoint request. If endpoints haven't changed recently, then this request will look stale, and currently we would just leave the watch open. Instead, it is paramount that we respond immediately, otherwise the cluster will get no endpoints. This code is copied verbatim from https://github.com/Kong/kuma/pull/331. Thanks to @yskopets.
jackkleeman
referenced
this pull request
in monzo/go-control-plane
Feb 28, 2020
When a cluster is warming, we will receive an endpoint request. If endpoints haven't changed recently, then this request will look stale, and currently we would just leave the watch open. Instead, it is paramount that we respond immediately, otherwise the cluster will get no endpoints. This code is copied verbatim from https://github.com/Kong/kuma/pull/331. Thanks to @yskopets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
go-control-planeto always respond toEDSrequests that are happening atcluster warming stageContext
We’ve run into an issue where
envoykeeps updatedclusterin awarming statefor indefinite amount of time.Such behaviour is explained in the
Resource warmingsection of thexDS Protocol(https://www.envoyproxy.io/docs/envoy/latest/api-docs/xds_protocol#resource-warming):In our case, while
Clusterdefinition is updated, endpoints do not change. That’s whygo-control-plane-based control plane doesn’t send a response toEDSrequest.Apparently, support for this use case is missing from
go-control-plane.