Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl): don't show builtin gateway spuriously offline #3465

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Gateways don't have inbounds.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 9, 2021 21:50
@codecov-commenter
Copy link

Codecov Report

Merging #3465 (b6c7295) into master (9dbcf4d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3465      +/-   ##
==========================================
- Coverage   52.31%   52.30%   -0.02%     
==========================================
  Files         940      940              
  Lines       54445    54445              
==========================================
- Hits        28484    28478       -6     
- Misses      23739    23751      +12     
+ Partials     2222     2216       -6     
Impacted Files Coverage Δ
.../resources/apis/mesh/dataplane_overview_helpers.go 100.00% <100.00%> (ø)
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/insights/resyncer.go 67.22% <0.00%> (-2.68%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 85.88% <0.00%> (+1.17%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/runtime/component/component.go 88.67% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbcf4d...b6c7295. Read the comment docs.

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 9, 2021 22:55
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice catch!

@michaelbeaumont michaelbeaumont merged commit a2b583f into kumahq:master Dec 10, 2021
@michaelbeaumont michaelbeaumont deleted the fix/gateway_cli_offline branch December 10, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants