fix(kuma-cp): use the hostname for gateway stats #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
approved these changes
Dec 10, 2021
The virtualhost name field is used for Envoy metrics, so using the actual hostname in this field rather than a xDS resource name results in Prometheus labels that are a lot more useable. This fixes #3320. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The virtualhost name field is used for Envoy metrics, so using the
actual hostname in this field rather than a xDS resource name results
in Prometheus labels that are a lot more useable.
Full changelog
N/A
Issues resolved
Fix #3320
Documentation
N/A
Testing
Manual testing on UniversalManual testing on KubernetesBackwards compatibility
UpdateUPGRADE.mdwith any steps users will need to take when upgrading.Addbackport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.