Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose initial token server with TLS on public interface #349

Merged
merged 3 commits into from
Oct 22, 2019
Merged

Expose initial token server with TLS on public interface #349

merged 3 commits into from
Oct 22, 2019

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

  • Initial Token Server can be now exposed outside localhost with TLS enabled. Clients that connect to this server are verified by their certificates. Certs have to be provided in Kuma CP configuration.
  • Cleaned up loader test so the assertions are not repeated.

yskopets
yskopets approved these changes Oct 18, 2019
View reviewed changes
pkg/tokens/builtin/server/dataplane_token_server_test.go Show resolved Hide resolved
pkg/tokens/builtin/server/dataplane_token_server_test.go Show resolved Hide resolved
pkg/config/token-server/config.go Outdated
}
}

// Dataplane Token Server configuration
type DataplaneTokenServerConfig struct {
// Port of the server
Port uint32 `yaml:"port" envconfig:"kuma_dataplane_token_server_port"`
// Public interface on which the SSL server will be exposed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it would be more clear to group fields under Local and Public

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, it is more clear.

@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/initial-token-metadata branch 3 times, most recently from e397bc5 to 33a9056 Compare October 22, 2019 13:49
@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from feature/initial-token-metadata to master October 22, 2019 14:45
@jakubdyszkiewicz jakubdyszkiewicz merged commit 49f2edf into master Oct 22, 2019
@jakubdyszkiewicz jakubdyszkiewicz deleted the feature/initial-token-ssl branch October 22, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @yskopets