ci: refactor Minikube example to reuse Docker images #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
ci/refactor-minikube-example
branch
14 times, most recently
from
04ba293
to
a10a065
Compare
yskopets
force-pushed
the
ci/refactor-minikube-example
branch
from
a10a065
to
6924bce
Compare
| @@ -0,0 +1,18 @@ | |||
| FROM alpine:3.10 | |||
There was a problem hiding this comment.
So why do we have this file? If the motivation is to have kumactl docker image faster, why not do something like this with all images?
There was a problem hiding this comment.
I've added a new commit to remove old Dockerfiles at the repo root.
Now, only 1 Dockerfile per component is left.
jakubdyszkiewicz
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary