Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test mTLS on Kubernetes #354

Merged
merged 2 commits into from
Oct 22, 2019
Merged

ci: test mTLS on Kubernetes #354

merged 2 commits into from
Oct 22, 2019

Conversation

yskopets
Copy link
Contributor

Summary

  • test mTLS on Kubernetes

@yskopets yskopets force-pushed the ci/test-mtls-on-kubernetes branch 3 times, most recently from b3d805c to 50b5ffb Compare October 21, 2019 23:43
@yskopets yskopets changed the base branch from master to ci/refactor-kumactl-workflow October 21, 2019 23:46
@yskopets yskopets changed the base branch from ci/refactor-kumactl-workflow to master October 22, 2019 10:08
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are writing integration/e2e tests in Make/bash.

It's good to have it right now, because we had a bug, but let's bring it on our next planning and see when can we find some space to design test framework.

@yskopets yskopets merged commit 00b0e7d into master Oct 22, 2019
@hutchic
Copy link

hutchic commented Oct 22, 2019

tavern ( https://taverntesting.github.io ) might work well here but could also be a bit of a square peg in a round hole

@yskopets yskopets deleted the ci/test-mtls-on-kubernetes branch October 23, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yskopets @hutchic @jakubdyszkiewicz