chore(e2e): apply test namespace helper #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of places in the e2e test suite were manually applying the test namespace to enable sidecar injection. There is already a framework helper to so that, so apply it consistently to make it obvious which approach is preferred. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #3550 +/- ##
==========================================
+ Coverage 51.59% 51.68% +0.09%
==========================================
Files 916 916
Lines 55508 55406 -102
==========================================
- Hits 28638 28637 -1
+ Misses 24581 24479 -102
- Partials 2289 2290 +1
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A number of places in the e2e test suite were manually applying the test
namespace to enable sidecar injection. There is already a framework
helper to so that, so apply it consistently to make it obvious which
approach is preferred.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Manual testing on UniversalManual testing on KubernetesBackwards compatibility
UpdateUPGRADE.mdwith any steps users will need to take when upgrading.Addbackport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.