Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): remove minikube jobs and use multiple k3d jobs #3572

Merged
merged 4 commits into from Jan 6, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Dec 17, 2021

Run against minimum and maximum supported k8s version in a k3d job
This enables us to get rid of minikube jobs

Signed-off-by: Charly Molter charly.molter@konghq.com

Summary

SUMMARY_GOES_HERE

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #3642
Fix #3245

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take
    when upgrading.
  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #3572 (0bfe4e5) into master (d35f508) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   51.08%   51.06%   -0.02%     
==========================================
  Files         925      925              
  Lines       56350    56350              
==========================================
- Hits        28786    28776      -10     
- Misses      25271    25284      +13     
+ Partials     2293     2290       -3     
Impacted Files Coverage Δ
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-5.13%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/insights/resyncer.go 71.16% <0.00%> (-2.46%) ⬇️
pkg/dns/vips_allocator.go 72.34% <0.00%> (-1.42%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️
pkg/kds/client/sink.go 59.45% <0.00%> (+5.40%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35f508...0bfe4e5. Read the comment docs.

@lahabana lahabana force-pushed the killMinikube branch 4 times, most recently from beb88c9 to bf69528 Compare December 17, 2021 14:33
Run against minimum and maximum supported k8s version in a k3d job
This enables us to get rid of minikube jobs

Signed-off-by: Charly Molter <charly.molter@konghq.com>
we now handle case where KIND_CLUSTER_NAME is not set

Signed-off-by: Charly Molter <charly.molter@konghq.com>
They are not providing a lot of value

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana marked this pull request as ready for review January 5, 2022 16:22
@lahabana lahabana requested a review from a team as a code owner January 5, 2022 16:22
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally!

Please also remember about removing related makefiles

@lahabana lahabana merged commit 03e2e0b into kumahq:master Jan 6, 2022
@lahabana lahabana deleted the killMinikube branch March 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make k3d/start target is broken remove legacy e2e tests
3 participants