Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gateway): change to prefixed autogenerated tag #3585

Merged
merged 1 commit into from Dec 23, 2021

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Closes #3515

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 20, 2021 13:41
@michaelbeaumont michaelbeaumont merged commit c310a61 into kumahq:master Dec 23, 2021
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Dec 23, 2021
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Dec 23, 2021
…hq#3585)"

This reverts commit c310a61.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Dec 23, 2021
…" (#3621)

Unfortunately tag values can't contain slashes. The previous format is at least consistent with Service's _svc.

This reverts commit c310a61.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
parkanzky pushed a commit that referenced this pull request Jan 6, 2022
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
parkanzky pushed a commit that referenced this pull request Jan 6, 2022
…" (#3621)

Unfortunately tag values can't contain slashes. The previous format is at least consistent with Service's _svc.

This reverts commit c310a61.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a sensible kuma.io/service tag from Gateway API Gateways
2 participants