Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document new backporting policy #3633

Merged
merged 2 commits into from Jan 4, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 3, 2022

Summary

Add backporting policy in PR template and CONTRIBUTING.md
Also remove unnecessary outdated TOC (github provides an autogenerated on already).

Documentation

Testing

  • [ ] Unit tests
  • [ ] E2E tests
  • [ ] Manual testing on Universal
  • [ ] Manual testing on Kubernetes

Backwards compatibility

  • [ ] Update UPGRADE.md with any steps users will need to take
    when upgrading.
  • [ ] Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@lahabana lahabana requested a review from a team as a code owner January 3, 2022 16:54
Add backporting policy in PR template and CONTRIBUTING.md

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana changed the title docs: Document new backporting policy docs: document new backporting policy Jan 3, 2022
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github provides an autogenerated on already

🤯

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #3633 (16964b0) into master (cf671dd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
- Coverage   51.25%   51.24%   -0.02%     
==========================================
  Files         921      921              
  Lines       55957    55957              
==========================================
- Hits        28682    28675       -7     
- Misses      24991    24996       +5     
- Partials     2284     2286       +2     
Impacted Files Coverage Δ
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-10.26%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 85.86% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf671dd...16964b0. Read the comment docs.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit 4ffa446 into kumahq:master Jan 4, 2022
parkanzky pushed a commit that referenced this pull request Jan 6, 2022
Add backporting policy in PR template and CONTRIBUTING.md

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana deleted the docs/new_backporting_policy branch March 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants