feat(kuma-cp) coordinates webservice #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/locations
branch
from
b07aa96
to
1b4016f
Compare
yskopets
reviewed
Oct 24, 2019
pkg/config/app/kuma-cp/config.go
Outdated
| @@ -74,6 +74,8 @@ type Config struct { | |||
| Defaults *Defaults `yaml:"defaults"` | |||
| // Reports configuration | |||
| Reports *Reports `yaml:"reports"` | |||
| // Hostname on which Kuma is exposed | |||
| Hostname string `yaml:"hostname" envconfig:"kuma_hostname"` | |||
There was a problem hiding this comment.
Let's group it under General field and move it to the top of Config
There was a problem hiding this comment.
Maybe rename it into one of RecommendedHostname, AdvertisedHostname, etc
There was a problem hiding this comment.
What goes to General? Should Environment also be in General?
There was a problem hiding this comment.
Let's start by moving only AdvertisedHostname into General.
And we can open a separate issue for doing the same for Environment.
Yes. There is #314 for that |
yskopets
approved these changes
Oct 29, 2019
|
moved into general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Endpoint that serves coordinates of various services in Kuma.
Questions
Should Kuma DP also use API Server to retrieve bootstrap coordinates? Right now we configure it with bootstrap url.
Issues resolved
Fix #315