Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kumactl) support for https dataplane token server #372

Merged
merged 5 commits into from
Nov 6, 2019
Merged

feat(kumactl) support for https dataplane token server #372

merged 5 commits into from
Nov 6, 2019

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Support for TLS dataplane token server.
Extended config for kumactl with arguments when adding new control plane.

@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/kumactl-dataplane-token-tls branch from e065e6d to 049614b Compare October 29, 2019 10:07
@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from feature/locations to master October 29, 2019 10:08
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/kumactl-dataplane-token-tls branch from 049614b to d510b6e Compare October 29, 2019 10:10
yskopets
yskopets reviewed Oct 29, 2019
View reviewed changes
app/kumactl/cmd/config/config_control_planes_add.go Outdated Show resolved Hide resolved
app/kumactl/cmd/config/config_control_planes_add.go Outdated Show resolved Hide resolved
pkg/config/app/kumactl/v1alpha1/config.proto Outdated Show resolved Hide resolved
pkg/config/app/kumactl/v1alpha1/config.proto Outdated Show resolved Hide resolved
pkg/tokens/builtin/server/dataplane_token_server_test.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/kumactl-dataplane-token-tls branch from ec7fd15 to 3a77260 Compare October 30, 2019 09:53
yskopets
yskopets reviewed Nov 4, 2019
View reviewed changes
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have feedback from @marco ?

app/kumactl/cmd/config/testdata/config-control-planes-add.01.golden.yaml Outdated Show resolved Hide resolved
app/kumactl/pkg/cmd/root_context.go Outdated Show resolved Hide resolved
pkg/util/http/tls.go Show resolved Hide resolved
app/kumactl/pkg/tokens/client.go Outdated Show resolved Hide resolved
app/kumactl/pkg/tokens/client.go Outdated Show resolved Hide resolved
pkg/config/app/kumactl/v1alpha1/config_helpers.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/kumactl-dataplane-token-tls branch from 3a77260 to 80745a0 Compare November 4, 2019 12:48
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team and yskopets November 4, 2019 12:48
yskopets
yskopets approved these changes Nov 6, 2019
View reviewed changes
app/kumactl/pkg/cmd/root_context.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feature/kumactl-dataplane-token-tls branch from e046938 to bcdcd33 Compare November 6, 2019 11:05
@jakubdyszkiewicz jakubdyszkiewicz merged commit 3db6638 into master Nov 6, 2019
@jakubdyszkiewicz jakubdyszkiewicz deleted the feature/kumactl-dataplane-token-tls branch November 6, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

Assignees

@jakubdyszkiewicz jakubdyszkiewicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @yskopets