Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwrite option #381

Merged
merged 7 commits into from
Nov 2, 2019
Merged

Conversation

Gabitchov
Copy link
Contributor

@Gabitchov Gabitchov commented Oct 27, 2019

Summary

Add the possibility to overwrite an existing control plane configuration.

Full changelog

  • Add --overwrite option to config control-planes add command
  • Add unit test

Issues resolved

Fix #380

@yskopets yskopets self-requested a review October 27, 2019 16:47
@yskopets yskopets added this to the 0.3.0 milestone Oct 27, 2019
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gabitchov Thanks a lot for working on it!

app/kumactl/cmd/config/config_control_planes_add.go Outdated Show resolved Hide resolved
docs/cmd/kumactl/HELP.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Please keep working on it! 👍

Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gabitchov Awesome!

Thanks a lot for your contribution!

Contributor T-shirt is on us! 😉

@yskopets yskopets merged commit 7ea75bc into kumahq:master Nov 2, 2019
@devadvocado
Copy link
Contributor

@Gabitchov Thank you for your help! Would you kindly send me an email at kevin.chen@konghq.com so I could coordinate the t-shirt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --overwrite option to kumactl config control-planes add command
3 participants