Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp): better logging on signing key creation #3897

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

The logs say

2022-02-21T13:29:34.894Z	INFO	defaults	default signing key created

This PR add context to those messages

Issues resolved

No issues reported

Documentation

No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner February 21, 2022 15:47
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 8c97401 into master Feb 22, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/default-key-logging branch February 22, 2022 13:21
bartsmykla pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants