perf(kuma-cp): static data source loader #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…rce-loader Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
michaelbeaumont
approved these changes
Feb 23, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…rce-loader Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3903 +/- ##
=======================================
Coverage 56.02% 56.02%
=======================================
Files 911 912 +1
Lines 54291 54318 +27
=======================================
+ Hits 30414 30433 +19
- Misses 21427 21434 +7
- Partials 2450 2451 +1
Continue to review full report at Codecov.
|
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Mar 3, 2022
See kumahq#3903 Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
added a commit
to michaelbeaumont/kuma
that referenced
this pull request
Mar 3, 2022
See kumahq#3903 Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
added a commit
that referenced
this pull request
Mar 3, 2022
See #3903 Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
See kumahq#3903 Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement static data source loader. This is data source loader that relies on static list of secrets.
It's more performant in cases when we already retrieved secrets like in XDS generation.
This PR also deprecates
filedata source. It cannot be used with XDS generation since we don't follow changes of the file. It will be removed in the next majorIssues resolved
Fix #3893
Documentation
Testing
Backwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy