-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inspect): support policies for gateways #3916
Merged
michaelbeaumont
merged 6 commits into
kumahq:master
from
michaelbeaumont:feat/inspect_gateway
Mar 3, 2022
Merged
feat(inspect): support policies for gateways #3916
michaelbeaumont
merged 6 commits into
kumahq:master
from
michaelbeaumont:feat/inspect_gateway
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
feat/inspect_gateway
branch
3 times, most recently
from
February 28, 2022 18:08
89e6d83
to
3d5649d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3916 +/- ##
==========================================
+ Coverage 55.82% 55.88% +0.06%
==========================================
Files 917 918 +1
Lines 54748 54815 +67
==========================================
+ Hits 30562 30634 +72
+ Misses 21746 21734 -12
- Partials 2440 2447 +7
Continue to review full report at Codecov.
|
michaelbeaumont
force-pushed
the
feat/inspect_gateway
branch
from
March 1, 2022 08:54
3d5649d
to
3d17de3
Compare
2 tasks
2 tasks
michaelbeaumont
changed the title
feat(inspect): add gateway policies
feat(inspect): show policies for gateways
Mar 1, 2022
michaelbeaumont
changed the title
feat(inspect): show policies for gateways
feat(inspect): support policies for gateways
Mar 1, 2022
michaelbeaumont
force-pushed
the
feat/inspect_gateway
branch
2 times, most recently
from
March 3, 2022 09:31
d769885
to
9b6f4db
Compare
lobkovilya
approved these changes
Mar 3, 2022
- [ ] TrafficPermission - handled by destination - [ ] FaultInjection - not yet supported - [x] RateLimit - [x] HealthCheck - [x] CircuitBreaker - [x] Retry - [x] Timeout - [x] TrafficTrace - [x] TrafficLogs Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/inspect_gateway
branch
from
March 3, 2022 11:41
f77b394
to
c8c01ae
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/inspect_gateway
branch
from
March 3, 2022 13:27
718930c
to
5702664
Compare
jakubdyszkiewicz
approved these changes
Mar 3, 2022
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
* feat(inspect): add gateway policies - [ ] TrafficPermission - handled by destination - [ ] FaultInjection - not yet supported - [x] RateLimit - [x] HealthCheck - [x] CircuitBreaker - [x] Retry - [x] Timeout - [x] TrafficTrace - [x] TrafficLogs * feat(gateway): add Gateway to gateway dataplane inspect result * test(api-server): update dataplane inspect response * test(api-server): add gateway dataplane inspect test * feat(inspect): make gateway dataplane response stable * chore(inspect): add explanatory comment on MeshGateway-level policies Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds inspect API support for dataplanes that are builtin gateways.
The
dataplanes/<dp>/policies
endpoint now returns either:which is
kuma/pkg/api-server/types/gateway.go
Lines 32 to 36 in 3d17de3
The idea is to show for each
GatewayRoute
that applies to theGateway
served by thisDataplane
, which policies apply to any destinations in that route. AppliedTrafficLog
andTrafficTrace
policies are shown on the top level of the result.An example might look like:
Alternative
We don't necessarily have to return the gateway -> route tree.
Another option would to add return a list of attachments at the top level, like for sidecar dataplanes, with a new value for
AttachmentEntry.type
, which would encode the route information somehow.Part of #3720