Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod): remove ginkgo v1 #3923

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Ends up being removed by go mod tidy.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner February 24, 2022 08:36
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartsmykla bartsmykla enabled auto-merge (squash) February 24, 2022 08:37
@lahabana
Copy link
Contributor

Should we do go mod tidy as part of make check?

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Feb 24, 2022

@lahabana this is also removed by make check on my machine (I assumed it did go mod tidy at some point)

@lahabana
Copy link
Contributor

Weird that ci doesn't fail with some changes being present then...

@michaelbeaumont
Copy link
Contributor Author

@lahabana I agree. I've definitely gotten the feeling there's significant non-determinism/incomprehensible logic in how go manages go.{sum,mod} given the amount of seemingly random changes I see in PRs here and other go projects...

@lahabana
Copy link
Contributor

Once I looked at it and one of the core issue was that we're pulling go mods to retrieve proto dependencies like envoy-validate for .e.g pulling these go mods update go.mod. There's multiple workaround this but someone needs to spend the time.

@lahabana
Copy link
Contributor

But yes go is weird with deps. I'm sure there's a logic I just don't get it :)

@bartsmykla bartsmykla merged commit ba6dc1b into kumahq:master Feb 24, 2022
@michaelbeaumont michaelbeaumont deleted the chore/ginkgo branch February 24, 2022 09:57
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants