-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go.mod): remove ginkgo v1 #3923
Conversation
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Should we do go mod tidy as part of make check? |
@lahabana this is also removed by |
Weird that ci doesn't fail with some changes being present then... |
@lahabana I agree. I've definitely gotten the feeling there's significant non-determinism/incomprehensible logic in how go manages |
Once I looked at it and one of the core issue was that we're pulling go mods to retrieve proto dependencies like envoy-validate for .e.g pulling these go mods update go.mod. There's multiple workaround this but someone needs to spend the time. |
But yes go is weird with deps. I'm sure there's a logic I just don't get it :) |
Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Summary
Ends up being removed by
go mod tidy
.