Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-dp): reduce max unix socket length to 104 #3951

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

nicoche
Copy link
Contributor

@nicoche nicoche commented Feb 28, 2022

Linux limit is 108 but it looks like BSD and OS X are 104

Signed-off-by: Nicolas Chariglione nicolas@koyeb.com

Summary

Fix #3950

Full changelog

Issues resolved

Fix #3950

Documentation

Testing

Let me know if we need a test there

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@nicoche nicoche requested a review from a team as a code owner February 28, 2022 16:45
Linux limit is 108 but it looks like BSD and OS X are 104

Signed-off-by: Nicolas Chariglione <nicoche@koyeb.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3951 (bce0cff) into master (32af52b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3951      +/-   ##
==========================================
- Coverage   55.90%   55.85%   -0.05%     
==========================================
  Files         916      916              
  Lines       54543    54543              
==========================================
- Hits        30491    30467      -24     
- Misses      21619    21634      +15     
- Partials     2433     2442       +9     
Impacted Files Coverage Δ
pkg/xds/envoy/sockets.go 77.77% <0.00%> (ø)
pkg/defaults/mesh.go 64.28% <0.00%> (-21.43%) ⬇️
pkg/defaults/mesh/signing_key.go 60.00% <0.00%> (-20.00%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-13.89%) ⬇️
pkg/defaults/mesh/mesh.go 79.48% <0.00%> (-5.13%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/core/secrets/manager/global_manager.go 39.39% <0.00%> (-3.04%) ⬇️
pkg/core/secrets/manager/manager.go 36.98% <0.00%> (-2.74%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/core/managers/apis/mesh/mesh_manager.go 46.91% <0.00%> (-2.47%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32af52b...bce0cff. Read the comment docs.

@jakubdyszkiewicz
Copy link
Contributor

Thanks for the contribution!

@jakubdyszkiewicz jakubdyszkiewicz merged commit e00d8d8 into kumahq:master Mar 1, 2022
@nicoche nicoche deleted the fix-unix-socket-truncate branch March 1, 2022 15:38
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Linux limit is 108 but it looks like BSD and OS X are 104

Signed-off-by: Nicolas Chariglione <nicoche@koyeb.com>

Co-authored-by: Nicolas Chariglione <nicoche@koyeb.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DP crashes when his name is too long on OS X
3 participants