fix(gateway): don't fail to create MeshGatewayInstance with multiple MeshGateway listeners on same port #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MeshGateway listeners on same port Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
lahabana
approved these changes
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #3955 +/- ##
==========================================
- Coverage 55.86% 55.85% -0.02%
==========================================
Files 916 916
Lines 54540 54544 +4
==========================================
- Hits 30471 30467 -4
- Misses 21627 21634 +7
- Partials 2442 2443 +1
Continue to review full report at Codecov.
|
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…MeshGateway listeners on same port (kumahq#3955) Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The semantics of this are handled by
MeshGateway