fix(api-server): set TrafficeLog/Trace on gateway inspect result #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
|
I really would have hoped this would count as an unused variable for some check |
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 14, 2022
…ahq#3972) * test(api-server): add top-level policy to gateway dataplane inspect test * fix(api-server): set TrafficeLog/Trace on gateway inspect result * test(api-server): update gateway dataplane inspect test after fix Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yeah...