New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): added locality aware lb for external service #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added possibility to route traffic to external services in multizone setup. When localityawareloadbalancing is enabled and zoneegress, and external service label kuma.io/zone: xxx traffic to the external service will be routed through zone where the external service belongs to. Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4048 +/- ##
========================================
Coverage 56.06% 56.06%
========================================
Files 919 920 +1
Lines 55169 55468 +299
========================================
+ Hits 30931 31099 +168
- Misses 21795 21918 +123
- Partials 2443 2451 +8
Continue to review full report at Codecov.
|
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
test/e2e/externalservices/localityawarelb_multizone/universal/locality_multizone_universal.go
Outdated
Show resolved
Hide resolved
test/e2e/externalservices/localityawarelb_multizone/k8s/locality_multizone_k8s.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
approved these changes
Mar 31, 2022
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added possibility to route traffic to external services in multizone setup.
When
localityawareloadbalancing
is enabled andzoneegress
, and external servicelabel kuma.io/zone: xxx traffic to the external service will be routed through
the zone where the external service belongs to.
The feature works when
routing.localityawareloadbalancing
androuting.zoneEgress
enabled andExternalService
needs to have a tagkuma.io/zone
.Full changelog
Issues resolved
Fix #3901
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy