feat(kuma-cp) serve gui server #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
commented
Nov 7, 2019
yskopets
suggested changes
Nov 8, 2019
jakubdyszkiewicz
force-pushed
the
feature/static-server
branch
2 times, most recently
from
1a1b31f
to
8c9483e
Compare
yskopets
suggested changes
Nov 13, 2019
yskopets
approved these changes
Nov 13, 2019
| @@ -232,6 +232,9 @@ generate/kumactl/install/control-plane: | |||
| go generate ./app/kumactl/pkg/install/k8s/control-plane/... | |||
| go generate ./app/kumactl/pkg/install/universal/control-plane/postgres/... | |||
|
|
|||
| generate/gui: ## Generate go files with GUI static files to embed it into binary | |||
There was a problem hiding this comment.
add generate/gui to the .PHONY list at the top
jakubdyszkiewicz
force-pushed
the
feature/static-server
branch
from
0715baf
to
494a565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Server for Kuma GUI. It is exposed on 5683 port and by default expose stuff under
guidirectory in the directory ofkuma-cpbinary.Questions
How to deploy this?
On Universal, I guess we will build files from kuma-gui and then include
guidirectory in final package.What about K8S? Should we build docker image with kuma-gui and then start it in the same pod as kuma-cp?