-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): unsafe delete #4136
Conversation
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
- Coverage 55.77% 55.76% -0.01%
==========================================
Files 932 932
Lines 56230 56257 +27
==========================================
+ Hits 31361 31374 +13
- Misses 22391 22403 +12
- Partials 2478 2480 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Bart Smykla <bartek@smykla.com>
Summary
Add ability to delete resources unsafe way. Why?
I was considering supporting this on Validator level, but I believe this is the responsibility of manager/webhook rather than validator. You should be able to swap a validator without worrying about this flag.
Documentation
- [ ] Link to the website documentation PRTesting
Backwards compatibility
- [ ] UpdateUPGRADE.md
with any steps users will need to take when upgrading.- [ ] Addbackport-to-stable
label if the code follows our backporting policy