fix(*): envoy build scripts #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Apr 29, 2022
parkanzky
pushed a commit
that referenced
this pull request
May 6, 2022
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
lukidzi
pushed a commit
that referenced
this pull request
May 11, 2022
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix envoy build scripts
Full changelog
ENVOY_DISTROenv was used to callbuild_${ENVOY_DISTRO}.shscript, which is correct only ifENVOY_DISTROiscentos. In other cases it should bebuild_${GOOS}.sh/opt/homebrew/binto bazel PATH when building envoy for darwin-arm64Issues resolved
N/A
Documentation
- [ ] Link to the website documentation PRTesting
Backwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy