feat(kuma-cp): XDS config dump on Global CP #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4301 +/- ##
==========================================
- Coverage 55.70% 55.52% -0.19%
==========================================
Files 935 940 +5
Lines 56434 56733 +299
==========================================
+ Hits 31439 31503 +64
- Misses 22518 22743 +225
- Partials 2477 2487 +10
Continue to review full report at Codecov.
|
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
May 19, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for executing XDS Config Dump on Global CP.
It establishes a pattern of exchanging information between Global CP and Zone CP aside of exchanging Kuma resources.
Support of XDSConfig stream inside
pkg/kds/muxmay not be the cleanest solution, but I'd rather postpone refactors to the moment we introduce streaming of resources to the same service (as described here #3789 (comment))Issues resolved
Fix #3789
Documentation
In progress
Testing
Backwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy