Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): added join host port to support ipv6 #4325

Merged
merged 1 commit into from
May 21, 2022
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 20, 2022

Summary

Changed way how create host:port to support ipv6.

Full changelog

  • [Implement ...]
  • [changed string concatenation to JontHostPort]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner May 20, 2022 17:45
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #4325 (13c39df) into master (d143ca3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4325      +/-   ##
==========================================
- Coverage   55.44%   55.42%   -0.02%     
==========================================
  Files         942      942              
  Lines       57064    57064              
==========================================
- Hits        31639    31629      -10     
- Misses      22927    22933       +6     
- Partials     2498     2502       +4     
Impacted Files Coverage Δ
pkg/core/tokens/default_signing_key.go 77.77% <0.00%> (-8.34%) ⬇️
pkg/core/secrets/manager/global_manager.go 42.42% <0.00%> (-3.04%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/plugins/resources/postgres/store.go 76.37% <0.00%> (-0.43%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d143ca3...13c39df. Read the comment docs.

Copy link

@afzal442 afzal442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg we always get caught with this one... @jakubdyszkiewicz now that we have more lightweight e2e test suites maybe it makes sense to have them run with ipv6 no?

@lahabana lahabana merged commit 9c3cd67 into master May 21, 2022
@lahabana lahabana deleted the fix/ipv6-test-support branch May 21, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants