Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): allow to pass more build args for docker image #4333

Merged
merged 1 commit into from
May 23, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 23, 2022

Summary

Sometimes we might need to pass more build args for docker image if we have parametrized more elements in Dockerfile.

Full changelog

  • [allow to pass more args for build script]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner May 23, 2022 16:30
@lukidzi lukidzi merged commit 76267d5 into master May 23, 2022
@lukidzi lukidzi deleted the chore/param-docker-build branch May 23, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants