feat(kuma-cp) validate traffic log #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/validate-traffic-log
branch
from
bdfd39d
to
1481c0e
Compare
yskopets
suggested changes
Nov 14, 2019
jakubdyszkiewicz
force-pushed
the
feature/validate-traffic-log
branch
from
1481c0e
to
7209b41
Compare
yskopets
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Traffic log validation.
Destination can only have service tag.
conforconf.backendcan be empty, because then we choosedefaultBackendfrom the mesh.Ideally we should also validate if the backend we are setting is specified in the mesh. Then we also need to think if we can remove the mesh if the backend is used in TrafficLog. This is dynamic validation (depends on some other resource) which we don't support yet. We can improve this in a separate PR.