Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Allow control-plane podAnnotations #4368

Merged
merged 3 commits into from
May 30, 2022

Conversation

sentinelleader
Copy link
Contributor

Summary

Allow helm to set custom pod annotations for control-plane pods

Full changelog

Adding an extra param controlPlane.podAnnotations in helm values file

Issues resolved

Fix #4367

Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #4368 (1b3087e) into master (7d6c0f5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4368      +/-   ##
==========================================
- Coverage   55.40%   55.40%   -0.01%     
==========================================
  Files         941      941              
  Lines       57126    57126              
==========================================
- Hits        31652    31651       -1     
  Misses      22971    22971              
- Partials     2503     2504       +1     
Impacted Files Coverage Δ
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/core/secrets/manager/global_manager.go 42.42% <0.00%> (-3.04%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/core/tokens/default_signing_key.go 86.11% <0.00%> (+8.33%) ⬆️
pkg/core/resources/store/customizable_store.go 77.77% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6c0f5...1b3087e. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. You need to run make test UPDATE_GOLDEN_FILES=true to update the golden files for the tests

@sentinelleader
Copy link
Contributor Author

Makes sense. You need to run make test UPDATE_GOLDEN_FILES=true to update the golden files for the tests

i see, thanks

Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartsmykla bartsmykla merged commit 1e8df29 into kumahq:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow helm chart to add custom pod Annotations
4 participants