-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Allow control-plane podAnnotations #4368
Conversation
Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #4368 +/- ##
==========================================
- Coverage 55.40% 55.40% -0.01%
==========================================
Files 941 941
Lines 57126 57126
==========================================
- Hits 31652 31651 -1
Misses 22971 22971
- Partials 2503 2504 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. You need to run make test UPDATE_GOLDEN_FILES=true
to update the golden files for the tests
i see, thanks |
Signed-off-by: Deepak Mohandas <deepak.mohandas@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Allow helm to set custom pod annotations for control-plane pods
Full changelog
Adding an extra param
controlPlane.podAnnotations
in helm values fileIssues resolved
Fix #4367