Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): add 'kuma' to CRD categories #4426

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Just an idea. Useful? Not useful?

$ kubectl get kuma
NAME                                                 AGE
circuitbreaker.kuma.io/circuit-breaker-all-default   106s

NAME                                          AGE
trafficpermission.kuma.io/allow-all-default   106s

NAME                              AGE
retry.kuma.io/retry-all-default   106s

NAME                                          AGE
serviceinsight.kuma.io/all-services-default   96s

NAME                                  AGE
timeout.kuma.io/timeout-all-default   106s

NAME                          AGE
meshinsight.kuma.io/default   96s

NAME                   AGE
mesh.kuma.io/default   106s

NAME                                     AGE
trafficroute.kuma.io/route-all-default   106s

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 3, 2022 15:18
@codecov-commenter
Copy link

Codecov Report

Merging #4426 (0aae15d) into master (180084f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4426      +/-   ##
==========================================
- Coverage   55.50%   55.46%   -0.05%     
==========================================
  Files         941      941              
  Lines       57681    57681              
==========================================
- Hits        32016    31991      -25     
- Misses      23120    23131      +11     
- Partials     2545     2559      +14     
Impacted Files Coverage Δ
...sources/k8s/native/api/v1alpha1/container_patch.go 100.00% <ø> (ø)
...urces/k8s/native/api/v1alpha1/zz_generated.mesh.go 46.12% <ø> (ø)
...ces/k8s/native/api/v1alpha1/zz_generated.system.go 44.18% <ø> (ø)
tools/policy-gen/protoc-gen-kumapolicy/crd.go 0.00% <ø> (ø)
tools/resource-gen/main.go 0.00% <ø> (ø)
pkg/clusterid/creator.go 73.33% <0.00%> (-13.34%) ⬇️
pkg/metrics/store/counter.go 74.54% <0.00%> (-10.91%) ⬇️
pkg/core/runtime/component/component.go 83.87% <0.00%> (-9.68%) ⬇️
pkg/plugins/common/postgres/listener.go 46.15% <0.00%> (-7.70%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-5.56%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180084f...0aae15d. Read the comment docs.

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful. Nice!

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) June 3, 2022 16:29
@michaelbeaumont michaelbeaumont merged commit 9770154 into kumahq:master Jun 3, 2022
@michaelbeaumont michaelbeaumont deleted the feat/k8s_crd_category branch June 3, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants