Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*): added proposal of PSAT #4432

Merged
merged 7 commits into from
Jun 8, 2022
Merged

docs(*): added proposal of PSAT #4432

merged 7 commits into from
Jun 8, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jun 6, 2022

Summary

A proposal on how can we reload the token to authenticate with kuma-cp.
#4121

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner June 6, 2022 17:47
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
Copy link
Contributor Author

lukidzi commented Jun 7, 2022

We're meant to move to MADR: https://github.com/kumahq/kuma/tree/master/docs/madr :)

True, forgot about this. Moved to the new model

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. It's a simple pragmatic fix.

docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4432 (446e703) into master (9770154) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4432      +/-   ##
==========================================
+ Coverage   55.52%   55.53%   +0.01%     
==========================================
  Files         941      941              
  Lines       57681    57681              
==========================================
+ Hits        32028    32036       +8     
+ Misses      23112    23104       -8     
  Partials     2541     2541              
Impacted Files Coverage Δ
...s/authn/api-server/tokens/admin_token_bootstrap.go 82.00% <0.00%> (-4.00%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️
pkg/clusterid/creator.go 100.00% <0.00%> (+13.33%) ⬆️
pkg/plugins/resources/postgres/events/listener.go 31.25% <0.00%> (+14.58%) ⬆️
pkg/plugins/common/postgres/listener.go 69.23% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9770154...446e703. Read the comment docs.

docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
docs/madr/decisions/002-psat.md Outdated Show resolved Hide resolved
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit 5124101 into master Jun 8, 2022
@lukidzi lukidzi deleted the docs/psat-proposal branch June 8, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants