chore(kuma-cp): improved xds logging #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lahabana
reviewed
Jun 7, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lahabana
approved these changes
Jun 10, 2022
lobkovilya
reviewed
Jun 10, 2022
| if statusTrackerLog.V(1).Enabled() { | ||
| log = log.WithValues("node", req.Node()) | ||
| } | ||
| log.Info("proxy connected") |
There was a problem hiding this comment.
maybe instead of
proxy connected {"proxyName": "redis"...
it can be
connected {"type": "dataplane", "name": "redis"...
so we could easily see if this is dataplane or zoneingress or zoneegress
There was a problem hiding this comment.
we already log the type "type", md.GetProxyType(), in 156 line. I'd rather keep "proxy connected" instead of "connected".
It's proxyName instead of name for consistency, see #4436 (comment)
lobkovilya
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves XDS logging. Right now you have 0 logs about XDS on INFO and a massive amount of logs on DEBUG.
Logs on debug are "cryptic" and require knowledge about the CP implementation (what is
OnStreamRequestetc).Logging entire DiscoveryRequest/Response even on debug was too much. Especially with gigantic
Nodeobject for every log.I was trying to pick the minimal amount of information that could inform the user what is going on with the XDS exchange without knowledge about implementation.
I was also considering implementing full resource logging on trace but
AnytoListener, butHttpConnectionManageris again marshaled toAnyAfter this change
Issues resolved
Fix #4033
Documentation
No docs.
Testing
Backwards compatibility
- [ ] UpdateUPGRADE.mdwith any steps users will need to take when upgrading.- [ ] Addbackport-to-stablelabel if the code follows our backporting policy