chore(kuma-cp): change config map reconciler log level #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
michaelbeaumont
approved these changes
Jun 7, 2022
lahabana
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These logs are confusing in my opinion.
Log says
updating VIPs, but we are really reconciling VIPs, it does not mean that we are making any change.VIPs updatedsuggest that VIPs were updated, but that might not be the case if nothing has changed.Processes like watchdogs, reconcilers etc. are executed periodically or on some action, but very often they don't change the state of the system. IMHO we should log the activity on V1 to reduce the noise and we should log the actual action on V0.
Change of state action is already logged in
vips_allocator.Issues resolved
No issues reported.
Documentation
- [ ] Link to the website documentation PRTesting
Backwards compatibility
UPGRADE.mdwith any steps users will need to take when upgrading.backport-to-stablelabel if the code follows our backporting policy